This repository has been archived by the owner on Mar 19, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR slims down the Dockerfile by using a python 3.8 base image where all the dependencies can be installed just fine.
It's also worth pointing out that a Dockerfile isn't like a shell script. All commands are executed, and are kept in the docker image as layers. So if you install a package, and remove it in a later step, the total image size isn't decreased. This is a good document that explains it more: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/
I've tested the image on my pc, and it seems to work just fine. I don't know how it will behave on a raspberry pi for example, but I assume it will just work.
Old image:
New image: