Skip to content
This repository has been archived by the owner on Mar 19, 2023. It is now read-only.

Slim down Dockerfile #63

Merged
merged 1 commit into from
Sep 2, 2021
Merged

Slim down Dockerfile #63

merged 1 commit into from
Sep 2, 2021

Conversation

michaelarnauts
Copy link
Contributor

This PR slims down the Dockerfile by using a python 3.8 base image where all the dependencies can be installed just fine.

It's also worth pointing out that a Dockerfile isn't like a shell script. All commands are executed, and are kept in the docker image as layers. So if you install a package, and remove it in a later step, the total image size isn't decreased. This is a good document that explains it more: https://docs.docker.com/develop/develop-images/dockerfile_best-practices/

I've tested the image on my pc, and it seems to work just fine. I don't know how it will behave on a raspberry pi for example, but I assume it will just work.

Old image:

# docker images robmarkcole/deepstack-ui
REPOSITORY                 TAG       IMAGE ID       CREATED        SIZE
robmarkcole/deepstack-ui   latest    4b589811ee05   5 months ago   2.36GB

New image:

# docker images deepstack-ui-new
REPOSITORY         TAG       IMAGE ID       CREATED         SIZE
deepstack-ui-new   latest    ad5f64b646ae   4 minutes ago   1.37GB

@robmarkcole
Copy link
Owner

Many thanks @michaelarnauts this is much closer to my original dockerfile here, all the additional dependencies were added to support ARM if I recall in #55

@robmarkcole robmarkcole merged commit 94e8d01 into robmarkcole:master Sep 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants