Skip to content

Commit

Permalink
proc: kpagecount/kpageflags code cleanup
Browse files Browse the repository at this point in the history
Move increments of pfn/out to bottom of the loop.

Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andi Kleen <andi@firstfloor.org>
Acked-by: Matt Mackall <mpm@selenic.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Wu Fengguang authored and torvalds committed Jun 17, 2009
1 parent 20a0307 commit ed7ce0f
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions fs/proc/page.c
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@

#define KPMSIZE sizeof(u64)
#define KPMMASK (KPMSIZE - 1)

/* /proc/kpagecount - an array exposing page counts
*
* Each entry is a u64 representing the corresponding
Expand All @@ -33,20 +34,22 @@ static ssize_t kpagecount_read(struct file *file, char __user *buf,
return -EINVAL;

while (count > 0) {
ppage = NULL;
if (pfn_valid(pfn))
ppage = pfn_to_page(pfn);
pfn++;
else
ppage = NULL;
if (!ppage)
pcount = 0;
else
pcount = page_mapcount(ppage);

if (put_user(pcount, out++)) {
if (put_user(pcount, out)) {
ret = -EFAULT;
break;
}

pfn++;
out++;
count -= KPMSIZE;
}

Expand Down Expand Up @@ -99,10 +102,10 @@ static ssize_t kpageflags_read(struct file *file, char __user *buf,
return -EINVAL;

while (count > 0) {
ppage = NULL;
if (pfn_valid(pfn))
ppage = pfn_to_page(pfn);
pfn++;
else
ppage = NULL;
if (!ppage)
kflags = 0;
else
Expand All @@ -120,11 +123,13 @@ static ssize_t kpageflags_read(struct file *file, char __user *buf,
kpf_copy_bit(kflags, KPF_RECLAIM, PG_reclaim) |
kpf_copy_bit(kflags, KPF_BUDDY, PG_buddy);

if (put_user(uflags, out++)) {
if (put_user(uflags, out)) {
ret = -EFAULT;
break;
}

pfn++;
out++;
count -= KPMSIZE;
}

Expand Down

0 comments on commit ed7ce0f

Please sign in to comment.