Skip to content

Commit

Permalink
Basic implementation of 'make headers_check'
Browse files Browse the repository at this point in the history
Based on the 'headers_install' target, this performs a basic sanity check
on the exported headers -- so far only checking that they do not include
any other headers which aren't selected for import, but easily extendable.

Signed-off-by: David Woodhouse <dwmw2@infradead.org>
  • Loading branch information
dwmw2 committed Jun 18, 2006
1 parent 8d730cf commit 6847535
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -866,6 +866,10 @@ headers_install: include/linux/version.h
$(Q)rm -rf $(INSTALL_HDR_PATH)/include
$(Q)$(MAKE) -rR -f $(srctree)/scripts/Makefile.headersinst obj=include

PHONY += headers_check
headers_check: headers_install
$(Q)$(MAKE) -rR -f $(srctree)/scripts/Makefile.headersinst obj=include HDRCHECK=1

# ---------------------------------------------------------------------------
# Modules

Expand Down
11 changes: 11 additions & 0 deletions scripts/Makefile.headersinst
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,11 @@ quiet_cmd_unifdef = UNIFDEF $(_dst)/$@
cmd_unifdef = $(UNIFDEF) $(srctree)/$(obj)/$@ | $(HDRSED) \
> $(INSTALL_HDR_PATH)/$(_dst)/$@ || :

quiet_cmd_check = CHECK $(_dst)/$@
cmd_check = $(srctree)/scripts/hdrcheck.sh \
$(INSTALL_HDR_PATH)/include \
$(INSTALL_HDR_PATH)/$(_dst)/$@

quiet_cmd_mkdir = MKDIR $@
cmd_mkdir = mkdir -p $(INSTALL_HDR_PATH)/$@

Expand Down Expand Up @@ -112,6 +117,11 @@ __headersinst: $(subdir-y) $(header-y) $(unifdef-y) $(altarch-y) $(objhdr-y)

.PHONY: $(header-y) $(unifdef-y) $(subdir-y)

ifdef HDRCHECK
# Rules for checking headers
$(objhdr-y) $(header-y) $(unifdef-y):
$(call cmd,check)
else
# Rules for installing headers

$(objhdr-y) $(subdir-y) $(header-y) $(unifdef-y): $(_dst)
Expand All @@ -134,6 +144,7 @@ $(header-y):
$(unifdef-y):
$(call cmd,unifdef)
endif
endif

hdrinst := -rR -f $(srctree)/scripts/Makefile.headersinst obj

Expand Down
8 changes: 8 additions & 0 deletions scripts/hdrcheck.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#!/bin/sh

for FILE in `grep '^#include <' $2 | cut -f2 -d\< | cut -f1 -d\> | egrep ^linux\|^asm` ; do
if [ ! -r $1/$FILE ]; then
echo $2 requires $FILE, which does not exist
exit 1
fi
done

0 comments on commit 6847535

Please sign in to comment.