drm/vc4: Fix oops when userspace hands in a bad BO.

We'd end up NULL pointer dereferencing because we didn't take the error path out in the parent. Fixes igt vc4_lookup_fail test. Signed-off-by: Eric Anholt <eric@anholt.net> Fixes: d5b1a78 ("drm/vc4: Add support for drawing 3D frames.") Cc: stable@vger.kernel.org
roblim · Aug 15, 2016 · 5474e11 · 5474e11
1 parent 71cfcb0
commit 5474e11
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/drivers/gpu/drm/vc4/vc4_gem.c b/drivers/gpu/drm/vc4/vc4_gem.c
@@ -585,7 +585,7 @@ vc4_cl_lookup_bos(struct drm_device *dev,
 
 fail:
 	drm_free_large(handles);
-	return 0;
+	return ret;
 }
 
 static int