Attempt to get working under PHP 8.1 #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Gonna test with all the other services at once, will post my results. |
|
@nigelgbanks This came up for discussion in the tech call today. I see it is still in Draft, is it good to go yet in your opinion? |
|
@nigelgbanks, if we just remove the composer.lock file, I think this can go in. I don't believe you introduced any PHP 8 specific code that would prevent us from using it with either PHP 7 or 8. |
nigelgbanks
force-pushed
the
upgrade-php
branch
from
a7ed652
to
510275a
Compare
- Removed lock file - Updated test matrix For reasons behind removing the lock file see: https://islandora.slack.com/archives/CM5PPAV28/p1659631615201049 Islandora/documentation#1908 (Removal approved) Instead we'll provide lock files in isle and ansible deployments.
nigelgbanks
force-pushed
the
upgrade-php
branch
from
510275a
to
4c37211
Compare
|
@seth-shaw-asu & @alxp this is good to review now. I was successfuly able to install it with PHP 7.4, 8.0, and 8.1 |
This was referenced Nov 9, 2022
seth-shaw-asu
approved these changes
Nov 16, 2022
|
@alxp, I forgot when I said I would take care of this one that it is a roblib repository. Could you go ahead and merge it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade symphony dependencies to ^4.4 to match up with Drupal 9
For reasons behind removing the lock file, see:
https://islandora.slack.com/archives/CM5PPAV28/p1659631615201049
Islandora/documentation#1908 (Removal approved)
Instead, we'll provide lock files in isle and Ansible deployments.