Skip to content
This repository has been archived by the owner on Feb 4, 2022. It is now read-only.

Fixes #227 - Update NuxtJS instructions #269

Merged
merged 1 commit into from
May 7, 2020
Merged

Fixes #227 - Update NuxtJS instructions #269

merged 1 commit into from
May 7, 2020

Conversation

fabiofdsantos
Copy link
Contributor

Update the instructions to use this plugin in NuxtJS as stated here. I've tested it myself.

(credits: @renzosunico)

@robinvdvleuten
Copy link
Owner

Thanks for your PR! Are you sure this is the correct way to use this? I am not a Nuxtjs user myself and can't validate this myself.

@fabiofdsantos
Copy link
Contributor Author

@robinvdvleuten
Here's is an alternative confirmed by NuxtJS maintainers: nuxt/nuxt#3031 (comment)

There's no need to use onNuxtReady. The post only makes a suggestion to bypass Webpack Hot Module Replacement (HMR) (if you are using it for development purposes).

So, by default the configuration should be without onNuxtReady. I've validated it in development & production for NuxtJS v2.12.2 (released on March 31).

@robinvdvleuten
Copy link
Owner

@fabiofdsantos thank you for checking it and confirming!

@robinvdvleuten robinvdvleuten merged commit 926dba3 into robinvdvleuten:master May 7, 2020
@robinvdvleuten
Copy link
Owner

@all-contributors please add @fabiofdsantos for doc

@allcontributors
Copy link
Contributor

@robinvdvleuten

I've put up a pull request to add @fabiofdsantos! 🎉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants