Skip to content

Conversation

@jutaz
Copy link
Member

@jutaz jutaz commented Jan 17, 2015

So this PR implements #7, #4, #5, #1, #2.

Fixes pluralization issues, and add fun! Now messages might looks like this:
screen shot 2015-01-18 at 12 19 52 am

@jutaz jutaz changed the title Fixed most of the issues and also adds moch more fun! Fixed most of the issues and also adds much more fun! Jan 17, 2015
@brianmuse
Copy link
Member

This is a pretty cool update. A couple thoughts, though:

  • Randomizing takes some of the fun out of it. I like that the amounts are entirely based on the amount of open PRs.
  • The random messages is a great idea, though some are a little silly. eg. "Sweat away those pounds." is fine, but "With ❤️ from 🌔" is a little strange. I'm not sure I like that random people can be singled out either, because it takes away from the solidarity of the whole thing.
  • Multiple exercises sorta complicates things, or turns it into too much of a workout. What's default behavior and what's configurable?

@jutaz
Copy link
Member Author

jutaz commented Jan 20, 2015

  • Randomizing is only done to distribute amount PR`s to exercises. This does not add or remove anything.
  • Agree. Just wanted more messages to start off. This needs some ❤️ from our poets /cc @zachdunn
  • This is the default behavior. Everything is configurable. Number of exercises, types of exercises, ratios, and so on.

@atticoos
Copy link

👍 for pushups, i want that unbalanced no-leg-day thing everyone seems to be doin!

@jutaz
Copy link
Member Author

jutaz commented May 19, 2015

@robinpowered/product-team Merge PLS, this adds double pushups for us

@Rican7
Copy link

Rican7 commented May 27, 2015

Not to speak for too many, but I know that most of the people that do the pushups together in the office simply do a 1-to-1 on the number of open pull requests (25 pushups for 25 PRs, regardless of PR age). Is there any way we can make the non-linear pushup calculation (and old count) an option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants