Skip to content

Conversation

@robinmoisson
Copy link
Owner

Based on #138.

@hurrymaplelad I thought it'd be easier to start from your branch and do some modifications here than make lots of tiny comments on the PR you opened - feel free to comment here and I'll update, I'm curious of your thoughts!

Aside for some naming details here are a few things I changed from your PR:

  • extract some common functions into other modules, especially related to templating/formating and functions I could extract from the main cli script
  • add a buildIndex.js in the build scripts, so we don't have to use npx staticrypt just to fill a template (I'm not too happy with the naming of file structure in that folder but that'll do - though open to suggestions)
  • a number of small renamings to names that are simpler to understand for me (I learned the word "transclude" from your PR, thanks! 🙂)
  • actually using the codec/cryptoEngine functions in the index.html file, since we are importing them here (I think you make that change in your "another take on webcrypto" PR)

This will create conflicts with that next PR, sorry about that. I'm hoping that with this structure there will just be a need to move impl-webcrypto into the cryptoEngine folder and adjust the cli/index.js which hasn't changed too much.

@robinmoisson robinmoisson self-assigned this Nov 12, 2022
@robinmoisson robinmoisson mentioned this pull request Nov 12, 2022
@robinmoisson
Copy link
Owner Author

Comments still welcome, I'm merging to merge the next PRs as well.

@robinmoisson robinmoisson merged commit 4ca89da into main Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants