Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #138.
@hurrymaplelad I thought it'd be easier to start from your branch and do some modifications here than make lots of tiny comments on the PR you opened - feel free to comment here and I'll update, I'm curious of your thoughts!
Aside for some naming details here are a few things I changed from your PR:
buildIndex.jsin the build scripts, so we don't have to usenpx staticryptjust to fill a template (I'm not too happy with the naming of file structure in that folder but that'll do - though open to suggestions)index.htmlfile, since we are importing them here (I think you make that change in your "another take on webcrypto" PR)This will create conflicts with that next PR, sorry about that. I'm hoping that with this structure there will just be a need to move
impl-webcryptointo thecryptoEnginefolder and adjust thecli/index.jswhich hasn't changed too much.