transport/cython-conductor: Do not raise CancelledErrors (fixes hanging recoveries for cython version) #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
cython version should behave the same as python version. This fixes a bug which causes the system to stall when a rebalance happens during recovery.
trauter
force-pushed
the
cython-conductor-cancel-fix
branch
from
3e50034 to
e0c7372
Compare
Codecov Report
@@ Coverage Diff @@
## master #571 +/- ##
=======================================
Coverage 98.43% 98.43%
=======================================
Files 98 98
Lines 10035 10035
Branches 1135 1135
=======================================
Hits 9878 9878
Misses 125 125
Partials 32 32 Continue to review full report at Codecov.
|
|
changed author email to match my github account for CLA check |
|
Can you create this PR against faust-streaming. We can merge this to master and create a release |
This was referenced Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cython version should behave the same as python version.
This fixes a bug which causes the system to stall when a rebalance happens during recovery.