Fix: Update historicals url construction #229 (#230)

Fixes #230
robinhood-unofficial · Apr 24, 2020 · 522d683 · 522d683
1 parent 0113d31
commit 522d683
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 10 deletions.
diff --git a/newsfragments/229.bugfix b/newsfragments/229.bugfix
@@ -0,0 +1 @@
+Updated the .get_historical_quotes() to use the URL method .with_query() in order to build a URL with params.
diff --git a/pyrh/robinhood.py b/pyrh/robinhood.py
@@ -185,16 +185,13 @@ def get_historical_quotes(self, stock, interval, span, bounds=Bounds.REGULAR):
         if isinstance(bounds, str):  # recast to Enum
             bounds = Bounds(bounds)
 
-        historicals = (
-            urls.HISTORICALS
-            + "/?symbols="
-            + ",".join(stock).upper()
-            + "&interval="
-            + interval
-            + "&span="
-            + span
-            + "&bounds="
-            + bounds.name.lower()
+        historicals = urls.HISTORICALS.with_query(
+            [
+                ("symbols", ",".join(stock).upper()),
+                ("interval", interval),
+                ("span", span),
+                ("bounds", bounds.name.lower()),
+            ]
         )
 
         return self.get(historicals)