Skip to content

Conversation

ursi
Copy link
Contributor

@ursi ursi commented Apr 20, 2020

This will allow people to specify a branch out of convenience, but when elm-git-install is run it will be converted into the branch's current hash so there will be no problems with reproducibility.

@ursi
Copy link
Contributor Author

ursi commented Apr 20, 2020

It looks like there's a bug where if you already have the dependency checked out and you put in "master" to try to update to the latest commit, it won't grab the latest one. I'll look into it at some point, just putting this here in case I don't get around to it soon enough.

@robinheghan
Copy link
Owner

It looks like there's a bug where if you already have the dependency checked out and you put in "master" to try to update to the latest commit, it won't grab the latest one. I'll look into it at some point, just putting this here in case I don't get around to it soon enough.

Does the same thing happen when putting in a branch you've put in before?

Seems like a thing that would be nice to fix before merging this in.

I'm so sorry it took me this long to respond 🙇

@ursi
Copy link
Contributor Author

ursi commented Mar 22, 2022

You know, I can't say. I've been away from this for quite some time now lol.

@robinheghan
Copy link
Owner

Very understandable 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants