fix(ui): update About dialog with contributor credits and green icon#240
fix(ui): update About dialog with contributor credits and green icon#240robinebers merged 3 commits intomainfrom
Conversation
Replace "Contributions welcome" with linked contributor names (validatedev, davidarny) and swap the outdated blue icon asset for the current green app icon. Co-authored-by: Cursor <cursoragent@cursor.com>
🤖 Augment PR SummarySummary: Updates the About dialog to credit contributors with clickable GitHub profile links. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR updates the About dialog to credit maintainers (validatedev and davidarny) with linked GitHub profiles and replaces the outdated blue icon in public/icon.png with the current green app icon from src-tauri/icons/128x128.png.
Changes:
- Replaced generic "Contributions welcome" text with specific maintainer credits
- Added clickable GitHub profile links for the two maintainers
- Updated icon file to match the current green branding
- Added comprehensive test coverage for the new contributor links
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/components/about-dialog.tsx | Added "Contributors" section with linked GitHub usernames for validatedev and davidarny |
| src/components/about-dialog.test.tsx | Updated test name and added test cases for contributor link rendering and click behavior |
| public/icon.png | Replaced blue icon with green app icon sourced from src-tauri/icons/128x128.png |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <p className="text-xs pt-1"> | ||
| Contributors:{" "} | ||
| <ExternalLink href="https://github.com/validatedev"> | ||
| validatedev | ||
| </ExternalLink> | ||
| ,{" "} | ||
| <ExternalLink href="https://github.com/davidarny"> | ||
| davidarny | ||
| </ExternalLink> | ||
| </p> |
There was a problem hiding this comment.
The hardcoded contributor list only includes validatedev and davidarny (who are maintainers per CONTRIBUTING.md), but excludes other significant contributors like MuhammadAli511, Rich627, AdamAmr05, and garanda21 who have made substantial contributions to the project. This creates several concerns:
- The list is manually maintained and will become outdated as more contributors join
- It's unclear what criteria determines inclusion (is it maintainer status? number of contributions? something else?)
- This could be perceived as unfairly excluding contributors who have made meaningful contributions
Consider either:
- Clarifying that this list represents "Maintainers" rather than "Contributors" (to align with CONTRIBUTING.md)
- Dynamically fetching contributors from GitHub API or a maintained contributor file
- Removing the section entirely and relying on the GitHub link where all contributors are visible
- Establishing clear criteria for inclusion in documentation
There was a problem hiding this comment.
Right. We'll rename it to maintainers.
| <p className="text-xs pt-1"> | ||
| Contributors:{" "} | ||
| <ExternalLink href="https://github.com/validatedev"> | ||
| validatedev | ||
| </ExternalLink> | ||
| ,{" "} | ||
| <ExternalLink href="https://github.com/davidarny"> | ||
| davidarny | ||
| </ExternalLink> | ||
| </p> |
There was a problem hiding this comment.
The PR is marked as a "Bug fix" in the description, but the changes are cosmetic improvements (updating contributor credits and icon). This would more accurately be categorized as "Other" or could be considered a documentation/UI improvement rather than a bug fix. While this doesn't affect the code itself, proper categorization helps with changelog generation and understanding the nature of changes.
There was a problem hiding this comment.
Copilot you're a nitpicker bro
Co-authored-by: Cursor <cursoragent@cursor.com>
Description
Replace "Contributions welcome" text in the About dialog with linked contributor names (validatedev, davidarny) pointing to their GitHub profiles. Swap the outdated blue
public/icon.pngwith the current green app icon sourced fromsrc-tauri/icons/128x128.png.Related Issue
N/A — cosmetic fix noticed during review.
Type of Change
Testing
bun run buildand it succeededbun run testand all tests passbun tauri devChecklist
mainbranchScreenshot
Made with Cursor
Note
Low Risk
Purely UI copy/link updates plus additional unit tests; no changes to app logic beyond opening external URLs already used in the dialog.
Overview
Updates the
AboutDialogfooter copy by replacing the generic “Contributions welcome” line with linked maintainer credits forvalidatedevanddavidarny.Extends
about-dialog.test.tsxto assert the maintainer links render and that clicking each opens the expected GitHub profile via the mockedopenUrlAPI.Written by Cursor Bugbot for commit bbe1406. This will update automatically on new commits. Configure here.
Summary by cubic
Updated the About dialog to show a Maintainers section with links to validatedev and davidarny, replacing the “Contributions welcome” text, and switched the app icon to the current green version. Extended tests to cover rendering of maintainer links and that clicks open the correct GitHub profiles.
Written for commit bbe1406. Summary will update on new commits.