Fix for basePath appending logic to fix Issue #1660

[robinGupta11392]

Change list

Fixed the logic of appending basepath to the Hub URL which fixes Issue appium#1660 - appium#1660.

AppiumDriverLocalService was not able to start with Appium CLI versions < 2 as the ping() method was not able to get the status URL properly. Fixed the logic of appending basepath to sanitise the user input and appending basepath with "/" in the end, if not provided by user.

Types of changes

What types of changes are you proposing/introducing to Java client?
Put an x in the boxes that apply

• [ x ] No changes in production code.
• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• [ x ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Details

Test Execution logs - https://gist.github.com/robinGupta11392/e8c37c7e10e03cd00a4d44d398402738
Issue fixed - appium#1660
Changed Classes:

• ServerBuilderTest
• AppiumDriverLocalService

Method Added:

• sanitizeBasePath

Method Modified:

• withBasePath

Test Added:

• checkAbilityToStartServiceUsingBasePath