check if it is running when calling start() #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -123,6 +123,9 @@ func (c *Cron) Entries() []*Entry { | |||
|
|
|||
| // Start the cron scheduler in its own go-routine. | |||
| func (c *Cron) Start() { | |||
| if c.running { | |||
| return | |||
| } | |||
There was a problem hiding this comment.
The method documentation says:
// Start the cron scheduler in its own go-routine.But it's not what this code does, so docs would need to be updated if this change is to be merged.
|
See #46 which was an identical issue. The conclusion seemed to be that it's better for your program to arrange it so that it doesn't call |
|
@shurcooL I think this nessesory to check running here. As |
| @@ -121,8 +121,11 @@ func (c *Cron) Entries() []*Entry { | |||
| return c.entrySnapshot() | |||
| } | |||
|
|
|||
| // Start the cron scheduler in its own go-routine. | |||
| // Start the cron scheduler in its own go-routine if it is not running, otherwize it does nothing. | |||
There was a problem hiding this comment.
// Start the cron scheduler in its own go-routine, or no-op if already started.
|
OK, I guess this comes up enough and it's easy to resolve that might as well.. small tweak to comment please! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix a bug,
call Start() more than once will start multiple run() goroutines to run the jobs.