Allow for more descriptive errors during parsing #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If Cron is not active when a schedule occurs, it's possible we'll miss a task that we need to run. We've seen this happen when schedules coincide with a deploy. This commit adds a configuration option which will allow us to set the initial start time. We can "catch up" missed tasks by passing the shutdown time on creation.
We've previously added support for setting the "epoch" for our cron; that is, when we should start scheduling from. However, we were also using the epoch as the initial time for computing how long to wait until the next job should run. This resulted in drift of `now - epoch`. With this commit the initial time is _always_ the current time; the epoch defaults to the current time, unless overridden.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a need to improve the error handling around the
Parsefunction. Specifically, ifItoafailed it yield a nasty error.I've only overhauled the cases that I need, but I'm happy to invent a couple other error types for completeness for the rest of
parse.go, but only if this changelist is something along the lines that you'd actually care to accept. If it isn't something you're interested in, no worries.Thanks for building the package!