Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add L support with no changes on the SpecSchedule structure or whatsoever #325

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rissw
Copy link

@rissw rissw commented Jul 12, 2020

It's a simple changes to support L in Day of month (only up to last 7 day before EOM, but if needed can be done up to 14 days), and also support last day occurrence in the month

@clarkmcc
Copy link

I would love to see this get reviewed and merged.

@narqo
Copy link

narqo commented Feb 20, 2022

@robfig what do you think about adding the support to L to the mainline?

The project's readme currently refers to Quartz Cron syntax, that has very useful features:

  • The ‘L’ character is allowed for the day-of-month and day-of-week fields.
  • The ‘W’ is used to specify the weekday (Monday-Friday) nearest the given day.
  • The ‘#’ is used to specify “the nth” XXX weekday of the month.

This extended syntax is also supported by AWS's EventBridge. It'd be very helpful to have those in the package, starting with the last "day of the month".

@wsq2025
Copy link

wsq2025 commented Apr 27, 2023

why L not be supported now????????????

@clarkmcc
Copy link

why L not be supported now????????????

This project has been abandoned. I've added support for this in my fork.

@prochac
Copy link

prochac commented Oct 8, 2023

why L not be supported now????????????

This project has been abandoned. I've added support for this in my fork.

Not very alive as well ...

@clarkmcc
Copy link

clarkmcc commented Oct 8, 2023

Not very alive as well ...

There are no open issues or PRs. If you'd like to request a feature, feel free to open an issue or PR. The library is as complete as I need it to be today.

@svanscho
Copy link

svanscho commented Sep 19, 2024

Is there any plan on merging this? I stumbled across this as we'd need something like this on our service that is running on k8s. K8s is using this under the hood.

@prochac
Copy link

prochac commented Sep 19, 2024

Is there any plan on merging this? I stumbled across this as we'd need something like this on our service that is running on k8s. K8s is using this under the hood.

The last commit was 4yo, WDYT.
K8s project (as the big one) needs to life-check its deps.
When I run into this issue, I have checked multiple deps, and not just this one is abandoned.

@prochac
Copy link

prochac commented Sep 19, 2024

Not very alive as well ...

There are no open issues or PRs. If you'd like to request a feature, feel free to open an issue or PR. The library is as complete as I need it to be today.

LoL So, you will do the sacrifice and be the merge master. No thanks.

This is not how you build the trustworthy project on GitHub.

@clarkmcc
Copy link

@prochac not trying to build a project, just need support for L expressions in my cron 😄. Feel free to use it, or create your own fork and merge the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants