Use osg::PI in preference to M_PI#1
Merged
robertosfield merged 1 commit intorobertosfield:masterfrom Jun 17, 2025
Merged
Conversation
Owner
|
The OSG provide PI implementation so this could be used instead without requiring a platform specific hack |
The C++ spec doesn't require cmath to provide M_PI etc. libc++ and libstdc++ both do automatically, but Microsoft's STL fences it off behind a define as they're not reserved names, so could conflict with spec-compliant user code. However, osg always provides osg::PI
AnyOldName3
changed the title
Contributor
Author
|
I noticed this never got sorted while tidying up some old browser tabs, so I've changed this to use |
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C++ spec doesn't require cmath to provide
M_PIetc. libc++ and libstdc++ both do automatically, but Microsoft's STL fences it off behind a define as they're not reserved names, so could conflict with spec-compliant user code.