Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added property description for path.sep #7 #15

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

mahesha1150
Copy link

Hi @roberto-butti, Please review the PR for #7. Let me know if there is anything I am missing. Thanks.

@vercel
Copy link

vercel bot commented Oct 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
some-drops-of-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 10:50am

@roberto-butti
Copy link
Owner

Hi @roberto-butti, Please review the PR for #7. Let me know if there is anything I am missing. Thanks.

Thank you @mahesha1150 for your contribution. Your PR is great.
You provided context and explained why the path.sep is important.
Also, the example you provided is good.If you want, you can add an additional example in the article combining the join function like:

const path = require('path');

const folderName = 'documents';
const fileName = 'file.txt';
console.log(['user', folderName, fileName].join(path.sep))

@roberto-butti roberto-butti added the hacktoberfest Issues opened for Hacktoberfest. Your contribution is welcomed label Oct 5, 2023
@mahesha1150 mahesha1150 closed this Oct 5, 2023
@mahesha1150 mahesha1150 reopened this Oct 5, 2023
@mahesha1150
Copy link
Author

mahesha1150 commented Oct 5, 2023

Thanks for the feedback. Please check if below lines are fine. I can create another PR with below changes.

//Another example of creating filePath using path.sep along with join function
console.log(['user', folderName, fileName].join(path.sep))

@mahesha1150
Copy link
Author

mahesha1150 commented Oct 5, 2023

Have added the example as suggested @roberto-butti.

@roberto-butti
Copy link
Owner

This is amazing , I'm going to merge your PR for "Some drops of JavaScript" :)
Thank you for the support and the high quality of the contribution.

@roberto-butti roberto-butti merged commit 519c442 into roberto-butti:main Oct 5, 2023
@roberto-butti
Copy link
Owner

@mahesha1150 your creation: https://drops-of-javascript.hi-folks.dev/03-var/02_path-sep/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues opened for Hacktoberfest. Your contribution is welcomed hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants