Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝 adds 05_getting-all-the-object-properties-attributes #10

Merged

Conversation

SyedaMahamFahim
Copy link
Contributor

Chapter 03 - 05_Getting all the Object properties/attributes: key()

@vercel
Copy link

vercel bot commented Oct 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
some-drops-of-javascript ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 11, 2023 7:50pm

@roberto-butti
Copy link
Owner

Thank you @SyedaMahamFahim, for the PR.
If you allow me, I would like to provide feedback on this.
I think that you explained well the keys() function.
But in general, I would like to provide more context in each explanation. For example, mention some use cases when the reader can use the function.
For example, walking through all the properties with a loop. Or counting the properties. Or checking the existence of some properties (with additional usage of other functions),.

I would like to add some tips, like about the order of the attributes etc.

If you think that "is too much" to add, i will be happy to merge this PR, and i will add this additional information.
Or if you prefer to add them, let me know, I am happy to support you. And thanks again for your contribution

@roberto-butti roberto-butti added the hacktoberfest Issues opened for Hacktoberfest. Your contribution is welcomed label Oct 4, 2023
@SyedaMahamFahim
Copy link
Contributor Author

Hey @roberto-butti, I've taken a look at chapter 3 style, the typeof was explained in a short term. so I thought to follow the style, But don't worry, I'm not done yet! I'll review it again make sure everything is perfect and provide an even more detailed explanation.

@roberto-butti
Copy link
Owner

Thank you @SyedaMahamFahim I'm going to merge this PR ... thank you for your all effort and high quality PRs.
Welcome to the "club"

@roberto-butti roberto-butti merged commit 5da30bd into roberto-butti:main Oct 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Issues opened for Hacktoberfest. Your contribution is welcomed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants