Skip to content

added ubuntu-22 compatibility #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hansmorb
Copy link

@hansmorb hansmorb commented Apr 30, 2022


name: Pull request
about: Describe the proposed change


Describe the change
Ubuntu 22 ships with PHP 8.1 by default, this adds the necessary directory and service

Testing
In case a feature was added, how were tests performed?

Local testing on Ubuntu 22.04 solves #1

Copy link
Owner

@robertdebock robertdebock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your input, one remark, for both changes. Let me know if you need help.

vars/main.yml Outdated
@@ -23,6 +23,7 @@ _php_fpm_directory:
Ubuntu-17: /etc/php/7.1/fpm
Ubuntu-18: /etc/php/7.2/fpm
Ubuntu-19: /etc/php/7.2/fpm
Ubuntu-22: /etc/php/8.1/fpm
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather have "Ubuntu" use /etc/php/8.1/fpm, like so:

   Ubuntu-18: /etc/php/7.2/fpm
   Ubuntu-20: /etc/php/7.4/fpm 
   Ubuntu: /etc/php/8.1/fpm

That structure hopefully works a little longer...

@hansmorb hansmorb requested a review from robertdebock May 10, 2022 10:07
@hansmorb
Copy link
Author

Bookworm is failing because it also depends on PHP 8.1., I have added a commit that should also solve that. I was unsure if I should apply the same structure there because Bookworm is supposed to release next year.

Isn't there a way to check the installed PHP Version instead of the system version? That would maybe solve some problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants