Fixed: windows edition find results background color, recently updated menu width, memory leaks, and font size inconsistence #193
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n, affecting Windows edition only.
…nstant value, 30.
…he font size combobox value to the default font size on startup in nbrowserwindow.cpp.
boo-yee
changed the title
boo-yee
changed the title
…er function to setEditorStyle(), in order that subsequent setting will not overwrite the former one.
is kept being pressed, in order to reduce the needless rendering, which increases the cpu usage and freeze the UI when passing by large notes.
|
thanks! |
boo-yee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Highlight all results of find for the Windows edition, just as Qt Creator does. Under Windows, the results of find have a light grey background, which is very uncognizable.
Limit the max length of the recently updated menu of the tray. Otherwise, when the titles are too long, the menu will occupy the whole screen.
Fix memory leaks caused by Qt Webview. Nixnote ram usage was always increasing, seldom decreasing.
Convert the font size value to pixels when calling QWebSettings::setFontSize() in appearancepreferences.cpp and global.cpp. As in the function of setFontSize, the unit of measurement of font size parameter is pixel, which differs with the one of the editor font size combobox whose unit is points, so we have to make a conversion.
And moved the code of setting checkbox style from NBrowserWindow constructer function to setEditorStyle(), in order that subsequent setting will not overwrite the former one.
Make the editor not render the note content when Key_Up or Key_Down is kept being pressed, in order to reduce the needless rendering, which increases the cpu usage and freeze the UI when passing by large notes.