Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/mx-1706-add-primary-source-filter #396

Merged
merged 4 commits into from
Feb 25, 2025
Merged

feature/mx-1706-add-primary-source-filter #396

merged 4 commits into from
Feb 25, 2025

Conversation

rababerladuseladim
Copy link
Contributor

@rababerladuseladim rababerladuseladim commented Feb 21, 2025 •
edited
Loading

Added

  • BREAKING: filter for had_primary_source to backend api connector

@rababerladuseladim rababerladuseladim mentioned this pull request Feb 21, 2025
Merged
esinsj
esinsj reviewed Feb 24, 2025
View reviewed changes
Copy link
Contributor

@esinsj esinsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the test actually test for finding a primary source? Like this the filter is skipped, or?

@rababerladuseladim
Copy link
Contributor Author

It's not skipped, it's merely mocked, like all the other tests of the backend. We could wire this up against an actual backend, similar to what happens during the editor integration tests. But this is beyond the scope of this ticket. And I think we do have tickets for integration testing already.

@cutoffthetop cutoffthetop merged commit 8c44bda into main Feb 25, 2025
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1706-add-primary-source-filter branch February 25, 2025 15:37
rababerladuseladim added a commit to robert-koch-institut/mex-editor that referenced this pull request Feb 28, 2025
@rababerladuseladim
Feature/mx 1706 add primary source filter (#261)
82b222f 
### PR Context
<!-- Additional info for the reviewer -->

- depends on
robert-koch-institut/mex-backend#259
- depends on robert-koch-institut/mex-common#396

for local testing, use mex-backend >= 0.30.2

### Added
<!-- New features and interfaces -->
- filter for hadPrimarySource
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esinsj esinsj esinsj left review comments

@cutoffthetop cutoffthetop cutoffthetop approved these changes

Assignees

@rababerladuseladim rababerladuseladim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rababerladuseladim @cutoffthetop @esinsj