Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/mx 1660 ldap search endpoint #350

Merged
merged 19 commits into from
Dec 12, 2024
Merged

Feature/mx 1660 ldap search endpoint #350

merged 19 commits into from
Dec 12, 2024

Conversation

vyvytranngoc
Copy link
Contributor

@vyvytranngoc vyvytranngoc commented Dec 12, 2024 •
edited by cutoffthetop
Loading

Changes

  • updated ldap search from name and familyname to one single attribute "displayname"

vyvytranngoc and others added 18 commits August 22, 2024 14:42
@vyvytranngoc
created extract_person(s) from ldap + test
2bf5862
@vyvytranngoc
started to write tests for ldap search endpoint
39b39d8
@vyvytranngoc
started to create tests for ldap search endpoint
8fc230e
@vyvytranngoc
merge with main
a43da16
@vyvytranngoc
minor changes in ldap extract
41d79b1
@vyvytranngoc @cutoffthetop
Apply suggestions from code review
be973d6 
Co-authored-by: Nicolas Drebenstedt <897972+cutoffthetop@users.noreply.github.com>
Signed-off-by: vyvytranngoc <tran-ngocv@rki.de>
@vyvytranngoc
fixing small lint issue
7aa423e
@vyvytranngoc
fixing small lint issue
740c494
@vyvytranngoc
fixing small lint issue
5fed9bf
@vyvytranngoc
fixing small lint issue
ed026d2
@vyvytranngoc
fixing small lint issue
764fde7
@vyvytranngoc
deleted get_person_by_id in ldap extractor
d932092
@vyvytranngoc
deleted tests for get_person_by_id in ldap extractor
ac94b18
@vyvytranngoc
Merge branch 'main' into feature/mx-1660-ldap-search-endpoint
604e52b
@vyvytranngoc
reformatting for linter
4ab469b
@vyvytranngoc
Merge branch 'main' into feature/mx-1660-ldap-search-endpoint
68e57cb
@vyvytranngoc
Merge branch 'main' of https://github.com/robert-koch-institut/mex-co…
14889c2 
…mmon into feature/mx-1660-ldap-search-endpoint
@vyvytranngoc
updated search for ldap to displayName
7530dfe
@vyvytranngoc vyvytranngoc mentioned this pull request Dec 12, 2024
Merged
cutoffthetop
cutoffthetop requested changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! we should just sync the CHANGELOG with the PR description

@vyvytranngoc @cutoffthetop
Update CHANGELOG.md
6809deb 
Co-authored-by: Nicolas Drebenstedt <897972+cutoffthetop@users.noreply.github.com>
Signed-off-by: vyvytranngoc <tran-ngocv@rki.de>
cutoffthetop
cutoffthetop approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@cutoffthetop cutoffthetop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright, perfect! i'll merge and create a new release

@cutoffthetop cutoffthetop merged commit 74bbb48 into main Dec 12, 2024
4 checks passed
@cutoffthetop cutoffthetop deleted the feature/mx-1660-ldap-search-endpoint branch December 12, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cutoffthetop cutoffthetop cutoffthetop approved these changes

Assignees

@vyvytranngoc vyvytranngoc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vyvytranngoc @cutoffthetop