Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unicode in xaml msgIds #20

Closed
D-Bullock opened this issue Oct 2, 2018 · 3 comments
Closed

Support unicode in xaml msgIds #20

D-Bullock opened this issue Oct 2, 2018 · 3 comments

Comments

@D-Bullock
Copy link

Currently if one is using unicode characters (say ™) then it's replaced with a ? in the xamlmessages.pot file

I think XGetText-Xaml.ps1:61 is to blame

@robert-j-engdahl
Copy link
Owner

According to https://www.gnu.org/software/gettext/manual/gettext.html#Preparing-Strings there is nothing that prevents us from using Unicode in our msgId and here https://www.gnu.org/software/gettext/manual/gettext.html#Names it is even encouraged.

Years ago, when source code would be ASCII, special characters would be written out in the msgId, in your case the source code would be "say^TM". And the translater would then be responsible for using the ™ symbol if it was available in his particular character set. But nowadays everyone should use UTF-8, and at least some form of Unicode so that is not really an issue (outside East Asia at least).

@robert-j-engdahl robert-j-engdahl changed the title Support unicode in xaml translations Support unicode in xaml msgIds Oct 2, 2018
@robert-j-engdahl
Copy link
Owner

The task is to change 'ascii' to 'utf-8' and make tests and examples that ensures the result works.

@robert-j-engdahl
Copy link
Owner

Failing tests are on the new https://github.com/robert-j-engdahl/ngettext-wpf/tree/msgid-unicode-support branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants