adjust shutdown process on the httpserver to remove fsm noise #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
httpserver.Runner
shutdown process had two concurrent paths that could trigger FSM state transitions: explicitStop()
calls and context cancellation. This could cause race conditions where both paths attempted to transition the FSM from Running to Stopping state simultaneously, resulting in "current state mismatch" warnings.This fixes that problem by consolidating all FSM transitions into a single shutdown() method. The Stop() method now only cancels the context, while the Run() method detects cancellation and calls shutdown() to handle state transitions. This eliminates the race condition by ensuring only one code path manages FSM state changes during shutdown.