fix race condition in httpcluster #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
This change also includes many adjustments to tests.
robbyt
force-pushed
the
rterhaar/httpcluster-race
branch
from
3a68cb5 to
80db02a
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rapidly unbinding/rebinding ports, there's a potential race condition when trying to bind to a port that is still being released by the OS. To work around this, I added a small delay as
restartDelayafter stopping, which isn't ideal- but it's a simpler alternative than testing if the port is freed before continuing.This also updates the way that an entries change set is created by adding a new interface method
buildPendingEntriesthat does a 'copy-on-write', returning an updated copy of itself, with the actions updated and any changes specified in the method input. It also changes theentriesconstructor to simplify it, previously it would take the new and old set of entries, updating them- this complexity was moved tobuildPendingEntries.This change also includes many adjustments to tests.