Skip to content

major reorg of machines to move files into sub-packages #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2025

Conversation

robbyt
Copy link
Owner

@robbyt robbyt commented Apr 8, 2025

No description provided.

@robbyt robbyt requested a review from Copilot April 8, 2025 22:32
Copy link

github-actions bot commented Apr 8, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 77 out of 77 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

machines/extism/compiler/errors.go:8

  • The error ErrNoInstructions was removed. Verify that this removal is intentional and that there are no dependencies on it; if it is still needed, consider reintegrating it or updating dependent code.
-	ErrNoInstructions     = errors.New("wasm bytecode has zero instructions")

machines/extism/compiler/compiler.go:26

  • The option type has been renamed from 'CompilerOption' to 'FunctionalOption'. Ensure that all documentation and consumers of NewCompiler are updated accordingly to use the new naming convention.
func NewCompiler(opts ...FunctionalOption) (*Compiler, error) {

Copy link

sonarqubecloud bot commented Apr 9, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
3.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@robbyt robbyt merged commit 9444a84 into main Apr 9, 2025
4 of 5 checks passed
@robbyt robbyt deleted the rterhaar/reorg branch April 9, 2025 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant