Skip to content

Update index.pug #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 8, 2025
Merged

Update index.pug #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c1acd17
Update index.pug
robbrad Apr 8, 2025
bac1a8c
Update main.yml
robbrad Apr 8, 2025
ef9ca96
Update main.yml
robbrad Apr 8, 2025
e989dc3
Update main.yml
robbrad Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
aws-region: us-east-1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI Code Review (Powered by Amazon Bedrock)

Here is my review of the code change:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI Code Review (Powered by Amazon Bedrock)

Use the correct repository name for the action.

The repository name for the GitHub Action has been updated from aws-sample/aws-genai-cicd-suite to aws-samples/aws-genai-cicd-suite. This change is necessary to reference the correct repository where the action is hosted.

-      uses: aws-sample/aws-genai-cicd-suite@stable
+      uses: aws-samples/aws-genai-cicd-suite@stable

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI Code Review (Powered by Amazon Bedrock)

Here is my review of the code change:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI Code Review (Powered by Amazon Bedrock)

Consider using relative paths for better portability.

The generate-unit-test-source-folder parameter is set to '.', which specifies the current directory as the source folder for generating unit tests. However, using an absolute path like this can make the workflow less portable across different environments or repositories. Consider using a relative path instead, such as ./src or ${GITHUB_WORKSPACE}/src, to improve the portability of the workflow.

generate-unit-test-source-folder: '.'

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI Code Review (Powered by Amazon Bedrock)

Here is my review of the code change:

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI Code Review (Powered by Amazon Bedrock)

Consider adding null check for nameObj.

The condition has removed the null check for nameObj. This change could potentially lead to null pointer exceptions if nameObj is undefined or null. Consider adding the null check to ensure defensive programming practices.

-  if (!nameObj || (!nameObj.firstName && !nameObj.lastName)) {
+  if (!nameObj.firstName && !nameObj.lastName) {

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI Code Review (Powered by Amazon Bedrock)

Update the reference to the AWS GenAI CI/CD suite action.

The code change updates the reference to the AWS GenAI CI/CD suite action from 'aws-sample/aws-genai-cicd-suite@stable' to 'aws-samples/aws-genai-cicd-suite@stable'. This update ensures that the workflow uses the latest stable version of the action.

-      uses: aws-sample/aws-genai-cicd-suite@stable
+      uses: aws-samples/aws-genai-cicd-suite@stable

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI Code Review (Powered by Amazon Bedrock)

Here are my review comments for the code changes in .github/workflows/main.yml:


- name: Intelligent GitHub Actions
uses: aws-sample/aws-genai-cicd-suite@stable
uses: aws-samples/aws-genai-cicd-suite@stable
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
aws-region: us-east-1
Expand All @@ -59,8 +59,8 @@ jobs:
generate-code-review-level: 'detailed'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI Code Review (Powered by Amazon Bedrock)

Consider keeping generate-unit-test enabled for better code coverage. Disabling unit test generation could lead to reduced test coverage and potentially introduce bugs. It's generally recommended to keep unit tests enabled to ensure code quality and maintainability.

generate-code-review-exclude-files: '*.md,*.json'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔍 AI Code Review (Powered by Amazon Bedrock)

Update generate-unit-test-source-folder to match the project structure. The change from 'src' to '.' suggests that the source code files are in the root directory. However, it's a best practice to have a dedicated src folder for source code. Consider updating this value to match the actual project structure.

-        generate-unit-test-source-folder: 'src'
+        generate-unit-test-source-folder: '.'

generate-pr-description: 'true'
generate-unit-test: 'true'
generate-unit-test-source-folder: 'src'
generate-unit-test: 'false'
generate-unit-test-source-folder: '.'
output-language: 'en'
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
4 changes: 2 additions & 2 deletions views/index.pug
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ extends layout

block content
h1.
Welcome to #{menuTitle}
Welcome to #{menuTitle} - the best hotel on earth

img(src='public/hotel_landing_pic.png' class='img-fluid' style='width:400px; height:400px;')
img(src='public/hotel_landing_pic.png' class='img-fluid' style='width:400px; height:400px;')