Added principal major and minor stress outputs & docs #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Czarified
reviewed
Sep 13, 2021
There was a problem hiding this comment.
I agree. These changes do not seem to conflict with the ongoing v2 work. Most of the changes here are just the black formatting. The two new methods for StressPost build on top of the pre-existing methods 👍🏻 . You could even leave the black formatting, if you wanted. I think we're moving that direction in the future.
|
Cheers @Czarified . I undid the black formatting after an errant save autoformat! I guess once the style is agreed for v2 we'll just pipe everything through a CI with style formatting in any case. The big battle will be agreeing line length 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this can be PR-ed without conflicting with the v2 plans.