-
Notifications
You must be signed in to change notification settings - Fork 108
Add rectangular CLT section to (new) timber sections library #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rectangular CLT section to (new) timber sections library #466
Conversation
Looks promising! I think this would be a worthy addition to I've also included @connorferster as a reviewer as I believe he has more timber expertise than myself! Looking forward to reviewing the complete PR! FYI - the docs for this PR can be found here. |
I think it looks good! @jchkoch Glad you dropped the timber rectangular section in favour of the CLT section. Setting the shear modulus of the cross-lams via the If we can get the tests passing, then I am good to go on this one. Edit: Just added a couple of comments. |
@connorferster Thanks for the comments. Unfortunately, I became somewhat busy and haven't managed to follow up. However, I should have a bit more time going forward. |
Thanks for checking in @jchkoch. If you don't mind I can update your feature branch to the current state of |
Hi @robbievanleeuwen, I have updated the pull request as discussed above to address @connorferster comments as well as merging the commits from the main branch into my feature branch. I have also updated the docs with the new function However, when validating the results of a geometric analysis (in the example jupyter notebook Computed:
I_eff,x = 1.388e+08 mm4 Validation values: |
Hi @jchkoch, thanks again for your hard work on this. I should have some time at the end of this week to review. Did you manage to get to the bottom of the validation issues? If not I can try figure it out as well :) |
I have not been able to figure out the validation issue up to now. I thought I would leave it and come back to it. I may also have a bit more time in the next few days to look at it again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a few small code/docs comments. Otherwise looking great! Thanks for adhering to the style and adding tests/docs!
Tomorrow I'll have a look at why the validation example isn't working as expected.
Hi @jchkoch, regarding the validation issues you were having, here is my working: x-axis bendingTimber0 Contribution
i.e. Timber90 Contribution
i.e. I_eff,xThe effective second moment of area with respect to the modulus for Timber0 can be calculated as follows:
This matches the output from y-axis bendingTimber0 Contribution
i.e. Timber90 Contribution
i.e. I_eff,yThe effective second moment of area with respect to the modulus for Timber0 can be calculated as follows:
This matches the output from Maybe double check your working for the y-axis bending, by inspection it should be stiffer than x-axis bending due to the greater depth in the y-direction. Maybe your validation example is for bending where you have the timber90 at the top and bottom and timber0 in the centre (i.e. bending for the section looking side on)? If this is the case you'd need to make a new geometry object with the materials arranged accordingly. |
Hi @robbievanleeuwen, validation seems to work. I think I managed to confuse myself with regard to the coordinate system used by section-properties. I was indeed trying to validate the second case for bending where you have the timber90 at the top and bottom and timber0 in the center. From a practical point of view for 2-way CLT design, the so-called major and minor plate bending directions are particularly interesting. Making a new geometry object works! Major (x-) axis bending (Timber0 at the top and bottom) Minor (z-) axis bending (Timber90 at the top and bottom) |
Thanks for your hard work on this @jchkoch, looks great! |
Feature Timber Sections
Discussion: #437
This is a start at adding timber cross-section analysis. Please let me know what you think of the approach to add timber sections. So far I have added geometry creation of layered timber sections. I have added tests for the code that I have written so far.
Moving forward I will be checking and validating the results from the cross-sectional properties calculated for the sections as well as the stress analysis modules.