Skip to content

Update steelsections.py to create bulb flat #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 16, 2022

Conversation

zmpulse
Copy link
Contributor

@zmpulse zmpulse commented Feb 9, 2022

Update steelsections.py to create bulb flat

@robbievanleeuwen
Copy link
Owner

@zmpulse there are some comments in your code which confuse me:

dzero = ((c + t * 0.5 - r - t * 0.5) ** 2 + (b - r - b + d) ** 2) ** 0.5
# build radius
"""
to be update to include small radius on all sharp edge
to be update for tangence of the oblic line :
points.append([(r**2)/(dzero**2)*(t * 0.5)+r/(dzero**2)*((dzero**2)-(r**2))**0.5*(d-b),
              r**2/dzero**2*(b-d)+r/dzero**2*(dzero**2-r**2)**0.5*(t*0.5)])
points.append([(r**2)/(dzero**2)*(t * 0.5)-r/(dzero**2)*((dzero**2)-(r**2))**0.5*(d-b),
              r**2/dzero**2*(b-d)-r/dzero**2*(dzero**2-r**2)**0.5*(t*0.5)])"""

Also dzero isn't currently being used. Is the implementation complete?

@robbievanleeuwen robbievanleeuwen self-assigned this Feb 22, 2022
@robbievanleeuwen robbievanleeuwen added the enhancement New feature or request label Feb 22, 2022
@robbievanleeuwen
Copy link
Owner

@zmpulse could you please clarify how the dimensions work? See below code (I have shifted the section so the bottom left corner is at (0, 0):

from sectionproperties.pre.library.steel_sections import bulb_section

geometry = bulb_section(d=250, d_b=30, b=50, t=12, r=10, n_r=16).shift_section(6)
geometry.plot_geometry()

This generates the following figure which I have marked up:

Figure_1

These dimensions do not seem to align with the dimensions I have provided. Further there are some sharp transitions between straight lines and radii which do not look right. Are you able to comment on these?

@robbievanleeuwen
Copy link
Owner

Hi @zmpulse wondering if you are still interested in working on this? If not, I will close this PR.

@zmpulse
Copy link
Contributor Author

zmpulse commented Mar 16, 2022

Hi Robbie,
I have followed the convention ISO code for bulb flat and vendor.
image
image

So the full width of the bulb is at web thickness and bulb width. So in our case 50mm+12mm=62mm so it is ok.
For the small radius you are rigth on all sharp edge there is a small radius. (mentionned in the comments """to be update to include small radius on all sharp edge""").
For the sharp edge mention on the tangential line I will cross scheck it.
MicrosoftTeams-image

Thanks Robbie

@zmpulse
Copy link
Contributor Author

zmpulse commented Mar 16, 2022

I have found the width and depth of bulb that you used lead to an angle out of the standard because they don't respect the 30° angle of profile.
image
The parameter are not respecting this so it generate sharp edge at tangential line.

So if we go one step forward we should be able to skip the bulb width value because it is strainghtly link to bulb height.

@robbievanleeuwen
Copy link
Owner

Hi @zmpulse, thanks for providing the above diagrams, this makes sense.

I agree that the bulb width should be removed as it overconstrains the dimensions.

Are you able to make the above change to the PR and I will review and merge?

Thanks :)

@zmpulse
Copy link
Contributor Author

zmpulse commented Apr 12, 2022

image
done I will implement it now in the code

enforcing the depth of the bulb d_b to standard value except if user specify differently.
@zmpulse
Copy link
Contributor Author

zmpulse commented Apr 12, 2022

it is made:
if d_b == float: d_b = r * np.cos(np.pi / 3) / np.cos(np.pi / 6) + r + c * np.tan(np.pi / 6)

@robbievanleeuwen robbievanleeuwen merged commit a00d58b into robbievanleeuwen:master May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants