feat: .xlsx doc
#11
Merged
feat: .xlsx doc
#11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whatrocks
requested changes
Nov 2, 2022
src/config/dataset-formats/xlsx.md
Outdated
| @@ -0,0 +1,23 @@ | |||
| # Xlsx(Microsoft Excel) | |||
|
|
|||
| Thanks to [calamine](https://github.com/tafia/calamine) crate, ROAPI supports the `.xlsx` file. | |||
There was a problem hiding this comment.
I don't think we need this reference line here (could get stale at some point). Could you please remove?
whatrocks
reviewed
Nov 2, 2022
|
|
||
| Thanks to [calamine](https://github.com/tafia/calamine) crate, ROAPI supports the `.xlsx` file. | ||
|
|
||
| To load the `.xlsx`, `sheet_name` needs to be specified in a config. |
There was a problem hiding this comment.
Maybe add:
"By default, most .xlsx files initially use Sheet1 as the sheet_name. Be sure to change this sheet_name as needed if your spreadsheet uses a different sheet_name."
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: roapi/roapi#218