make browsershot wait until network idle on ExecuteJavascriptMiddleware #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Psalm seems to be complaining about this change. I had a quick look at it and it looks like we just have to suppress the error. The problem is that the return type of |
ksassnowski
reviewed
Sep 9, 2022
|
Fixes #55 Alright, looks good to me! Thanks a lot for the contribution and congrats on your first open source contribution! I'll tag a new release with change later 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Kai,
As requested here is the pull request for making Browsershot wait until network idle on the ExecuteJavascriptMiddleware.
This is my first Open Source pull request - so thanks for your patience!
Best,
Chris