Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Botan's "warning: 'Kyber1024' is deprecated" #2247

Open
ni4 opened this issue Jun 24, 2024 · 5 comments
Open

Fix Botan's "warning: 'Kyber1024' is deprecated" #2247

ni4 opened this issue Jun 24, 2024 · 5 comments

Comments

@ni4
Copy link
Contributor

ni4 commented Jun 24, 2024

Description

The following warning is issued if PQC support is enabled:

warning: 'Kyber1024' is deprecated: Use Kyber1024_R3 [-Wdeprecated-declarations]
    Botan::KyberMode result = Botan::KyberMode::Kyber1024;
@ni4
Copy link
Contributor Author

ni4 commented Jun 24, 2024

cc @falko-strenzke @TJ-91

@falko-strenzke
Copy link
Contributor

OK, we will take care, hopefully in the next week.

@TJ-91
Copy link
Contributor

TJ-91 commented Jul 9, 2024

Botan renamed the enum values and deprecated the old ones. Botan 3.0 up to 3.1.1 only know the old values, 3.2.0 and upwards know the new values and the deprecated old values. I will make a PR to fix this for the time being. We won't need the fix any more when Botan releases the final ML-KEM implementation and we switch to that.

Also note that Botan 3.2.0 (and probably some versions below, I did not check) will emit a lot of warnings about deprecated Kyber 90s. However, this is a problem in the Botan Header and I cannot really do anything here. Newer versions are fine.

@ni4
Copy link
Contributor Author

ni4 commented Jul 29, 2024

Quick look at https://pkgs.org/search/?q=Botan shows that most systems use Botan 2.x, and ones which use 3.x are already 3.2+. So probably it would be easier solution to require Botan 3.2.+ if PQC is enabled, I doubt that somebody would stick to 3.1.

TJ-91 added a commit to TJ-91/rnp that referenced this issue Jul 30, 2024
@TJ-91
Copy link
Contributor

TJ-91 commented Jul 30, 2024

That's easier, yes. I changed it to require Botan 3.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants