Fixed Issue : #3756 ( Mapbox [error] ViewTagResolver)

[Med-Li-Jr]

• It's a fix for this issue : [Bug]: Random error: “Mapbox [error] ViewTagResolver | view: null found with tag: xxxx but it's either null or not the correct type”. #3756

Description

Fixes #3756
File Changed : MapView.tsx

Added your feature that allows ...

Checklist

• I've read CONTRIBUTING.md
• I updated the doc/other generated code with running yarn generate in the root folder
• I have tested the new feature on /example app.
  • In V11 mode/ios
  • In New Architecture mode/ios
  • In V11 mode/android
  • In New Architecture mode/android
• I added/updated a sample - if a new feature was implemented (/example)

Screenshot OR Video

Component to reproduce the issue you're fixing

[mfazekas]

I don't think that this is good way to solve the issue.
mapView will be null if on layout has not been called yet.

Can't we just add an else to set mapView to an empty fragment instead of null?

if (this.state.isReady) {
  ...
} else {
  mapView = <></>
}

[LukasB-DEV]

@Med-Li-Jr code works. @mfazekas your suggestion does not work

[Med-Li-Jr]

@mfazekas, yeah me too, I didn't think it was a good way to solve it, but it was the only one amongs the things I tried that solved it on my side, I tried the following, but other errors appeared :

• Attemp 1 :

     let mapView = {} as NativeMapViewActual;
     if (this.state.isReady) {
        ...
      }
  

• Attemp 2 :

      let mapView = <RNMBXMapView> </RNMBXMapView>;
      if (this.state.isReady) {
        ...
      }
  

• Attemp 3 :

      let mapView = <></>;
      if (this.state.isReady) {
        ...
      }
  

• etc....

[Med-Li-Jr]

@LukasB-DEV, I see, then just changed it on your local code, maybe later, there will be an update that will fix it.

[mfazekas]

@Med-Li-Jr is there a code to reproduce the issue? It's not clear in #3756 how to reproduce the issue

[Med-Li-Jr]

@mfazekas it's a new project with the version 10.1.37, I just tried to create a new complete project with the latest version of expo and rnmapbox, but it didn't work too.

Step to reproduce the issue :

• npx create-expo-app --template default@53.0.7
• npm i @rnmapbox/maps@10.1.37
• npm run reset-project

in the app/index.tsx file :

  import Mapbox from '@rnmapbox/maps';
  import React from 'react';
  import { StyleSheet, View } from 'react-native';
  
  Mapbox.setAccessToken('xxxxxxxxxxxxxxxx');
  
  const App = () => {
    return (
      <View style={styles.page}>
        <View style={styles.container}>
          <Mapbox.MapView style={styles.map} />
        </View>
      </View>
    );
  }
  
  export default App;
  
  const styles = StyleSheet.create({
    page: {
      flex: 1,
      justifyContent: 'center',
      alignItems: 'center',
    },
    container: {
      height: 300,
      width: 300,
    },
    map: {
      flex: 1
    }
  });

• npx expo prebuild --clean
• npm run android