Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android camera event fixes + misc cleanup #367

Merged
merged 2 commits into from
Sep 5, 2019
Merged

Android camera event fixes + misc cleanup #367

merged 2 commits into from
Sep 5, 2019

Conversation

kristfal
Copy link
Member

@kristfal kristfal commented Sep 5, 2019

Fixes #323.

@kristfal kristfal requested a review from mfazekas September 5, 2019 12:45
This was referenced Sep 5, 2019
Closed
Closed
mfazekas
mfazekas approved these changes Sep 5, 2019
View reviewed changes
Copy link
Contributor

@mfazekas mfazekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what part was the camera event fixes maybe for next time it's better to do as 2 commits (or even 2 prs) on refacoring, and one fixing a specific issue.

javascript/components/Camera.js Outdated Show resolved Hide resolved
javascript/utils/AnimatedPoint.js Outdated Show resolved Hide resolved
javascript/index.js Show resolved Hide resolved
javascript/utils/geoUtils.js Outdated Show resolved Hide resolved
@kristfal
Copy link
Member Author

kristfal commented Sep 5, 2019

FYI, the actual fixes are here: https://github.com/react-native-mapbox-gl/maps/pull/367/files#diff-83bd90811e16ee14c9357ca5dd70f50cR412

Yes, will split next time.

@kristfal kristfal merged commit 16c83f7 into master Sep 5, 2019
@ferdicus ferdicus deleted the FIX-323-android-camera-changes branch March 12, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfazekas mfazekas mfazekas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

onRegionIsChanging is not working on Android.
2 participants
@kristfal @mfazekas