Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(turf): update to version 6.5.0 #1638

Merged
merged 4 commits into from
Nov 17, 2021
Merged

build(turf): update to version 6.5.0 #1638

merged 4 commits into from
Nov 17, 2021

Conversation

lisabaut
Copy link
Contributor

@lisabaut lisabaut commented Nov 17, 2021

Description

This is a clean up PR which happend due to the dependency update PR for eslint-plugin-import

Eslint correctly pointed to non existend types from turf.
Updating the libs to version 6.5.0 helped.

This PR includes also two refactorings:

  • replace convertDistance with convertLength (convertDistance was removed in version 5.0.0)
  • point to the file which contains the Feature type

Please see that the tests are failing!
This is not due to this PR but coming from this commit here instead:
https://github.com/react-native-mapbox-gl/maps/actions/runs/1461266314
=> rebased with master again

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with running yarn lint:fix in the root folder
  • I updated the documentation with running yarn generate in the root folder
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

Screenshot OR Video

Copy link
Member

@ferdicus ferdicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @lisabaut, thanks for your contribution.

Looks good to me, feel free to merge 👍🏿

@lisabaut lisabaut merged commit f4e8163 into master Nov 17, 2021
@lisabaut lisabaut deleted the build/update-turf branch November 17, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants