refactor(example): remove unused modules and scripts #1618
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While taking care of the dependabot PRs I saw that some modules are not in use in the
example
app:npm
url
buffer
Please take a closer look that I am not mistaken.
But in my opinion it looks like as these can be removed.
Additionally I found the script
upgradeExample.sh
which was created 2 years ago and contains hard coded module versions which - if this script is used by people - should acually be maintained and upgraded too with each dependabot PR, correct? But as I could not find any usage of this script nor a hint in the docs I removed it as well.Also because there are other ways on how to upgrade react-native (upgrade helper, CLI => see the docs)
After the merge I would close this PR here then: https://github.com/react-native-mapbox-gl/maps/pull/1610
Checklist
yarn lint
yarn generate
CHANGELOG.md
index.d.ts
)/example
)Screenshot OR Video