Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(example): remove unused modules and scripts #1618

Merged
merged 3 commits into from
Nov 5, 2021

Conversation

lisabaut
Copy link
Contributor

@lisabaut lisabaut commented Nov 4, 2021

Description

While taking care of the dependabot PRs I saw that some modules are not in use in the example app:

  • npm
  • url
  • buffer

Please take a closer look that I am not mistaken.
But in my opinion it looks like as these can be removed.

Additionally I found the script upgradeExample.sh which was created 2 years ago and contains hard coded module versions which - if this script is used by people - should acually be maintained and upgraded too with each dependabot PR, correct? But as I could not find any usage of this script nor a hint in the docs I removed it as well.
Also because there are other ways on how to upgrade react-native (upgrade helper, CLI => see the docs)

After the merge I would close this PR here then: https://github.com/react-native-mapbox-gl/maps/pull/1610

Checklist

  • I have tested this on a device/simulator for each compatible OS
  • I formatted JS and TS files with yarn lint
  • I updated the documentation yarn generate
  • I mentioned this change in CHANGELOG.md
  • I updated the typings files (index.d.ts)
  • I added/ updated a sample (/example)

Screenshot OR Video

@lisabaut lisabaut requested a review from ferdicus November 4, 2021 14:54
@ferdicus
Copy link
Member

ferdicus commented Nov 5, 2021

Thanks for opening this @lisabaut,
seems like these are only required for the upgradeExample script - good find 👍🏿

@RobertSasak, as you introduced this script - do you think this is still relevant?

Cheers 🍻

CHANGELOG.md Show resolved Hide resolved
@RobertSasak
Copy link
Contributor

Good job. The upgradeExample.sh is not needet any more and can be deleted.

@ferdicus ferdicus merged commit 4060e78 into master Nov 5, 2021
@ferdicus ferdicus deleted the refactor/remove-unused branch November 5, 2021 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants