feat(dashboard): add link with phone number pairing code UI - #551
Merged
rmyndharis merged 2 commits intoJun 30, 2026
Merged
Conversation
… a11y, state) - i18n: add the 9 missing locale translations for the sessions.pairing block, plus invalidPhone and waitingConnection keys (the latter referenced a key that existed in no locale) — i18n:check is green again - CSS: scope every .pairing-* selector under .sessions-page so the styles.scope guard passes; remove the duplicate .pairing-instructions and the dead .pairing-step rules - UX: show a phone-specific validation message instead of the session-name error, and reset pairing state whenever the modal (re)opens so a fresh session never shows a stale code or number - a11y: associate the phone label, use type=tel + inputMode=numeric + maxLength, disable Generate until the number is valid, add tab/tabpanel roles, and move the error banner to a theme-aware class that is readable in dark mode
Owner
|
Thanks for this, @akash247777 — really nice contribution. The pairing-code endpoint has existed on the backend for a while with no way to reach it from the dashboard, so this fills a genuine gap, and the QR ⇄ phone tab flow reads well. I've pushed one follow-up commit on top to get it merge-ready against our CI gates and a few UX details: Required for CI
Correctness / UX
Accessibility / polish
Full gate is green locally (build, unit tests, eslint, prettier, i18n parity, scope guard); CI is running now. Merging once it's green. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds the frontend dashboard UI for the "Link with Phone Number" pairing code feature.
While the NestJS backend API endpoint (
POST /api/sessions/:id/pairing-code) was already implemented, there was no way to request or view the pairing code from the dashboard interface.Key Changes
ABCD - 1234) for high readability.Type of Change
Checklist
Screenshots