Skip to content

Improvement/block sync errors #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 21, 2022
Merged

Improvement/block sync errors #12

merged 2 commits into from
Jan 21, 2022

Conversation

@yornaath
Copy link
Contributor

@yornaath yornaath commented Jan 21, 2022 •
edited
Loading

Added state for errors and hooks to retrieve them by api provider id:

// New context state
SubstraHooksContext {
  ...
  errorsState: ErrorsState;
  errorsDispatch: Dispatch<ErrorsActions>;
}

// Component Hook
const blockSyncError = useBlockSyncError(apiProviderId);

Yuripetusko
Yuripetusko approved these changes Jan 21, 2022
View reviewed changes
Copy link
Contributor

@Yuripetusko Yuripetusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks

@yornaath yornaath requested a review from Yuripetusko January 21, 2022 11:49
@yornaath yornaath merged commit f742efb into master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yuripetusko Yuripetusko Awaiting requested review from Yuripetusko

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yornaath @Yuripetusko