-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cached, named Visibility profiles #5074
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To benchmark this, I modified schema = Class.new(ProfileLargeResult::Schema) do
# def self.visible?(member, context)
# sleep 0.001
# super
# end
end
schema2 = Class.new(schema) {
use GraphQL::Schema::Visibility
}
document = ProfileLargeResult::ALL_FIELDS
Benchmark.ips do |x|
x.config(time: 10)
x.report("[WARDEN] Querying for #{ProfileLargeResult::DATA.size} objects") {
schema.execute(document: document)
}
x.report("[PROFILE] Querying for #{ProfileLargeResult::DATA.size} objects") {
schema2.execute(document: document)
} The performance was about the same between the two (Warden a bit faster? within the margin of error.), except when a cached visibility profile was used and Visibility::Profile uses a hair less memory (less than 1% difference). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aims to add to improvements to GraphQL-Ruby's (forthcoming) schema visibility system.
.visible?
during execution)dynamic: true
, which is how the current visibility system always works, calling.visible?
for every schema member on every query.Part of #5014
TODO
preload: true
(defaults to true whenRails.env.production?
)Accept configuredvisible_in: ...
or similar, for named visibility profilesVisibility::Subset
=>Visibility::Profile
Visibility::Profile