Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose parser tokens_count #5066

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

ravangen
Copy link
Contributor

Objective

Ability to apply max_query_string_tokens setting without breaking any existing operations.

Problem

We don't know the current distribution of the size of the tokens in existing operations.

Proposal

Expose tokens_count on Parser#tokens_count. Trigger parsing if not already done.

Outcome

To gather data, temporarily swap from the convenient GraphQL.parse to GraphQL::Language::Parser.new (or similar)

@rmosolgo
Copy link
Owner

Cool, thanks!

@rmosolgo rmosolgo added this to the 2.3.15 milestone Aug 15, 2024
@rmosolgo rmosolgo merged commit fc7082d into rmosolgo:master Aug 15, 2024
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants