Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GraphQL::Current, test with ActiveRecord::QueryLogs #5034

Merged
merged 8 commits into from
Aug 1, 2024

Conversation

rmosolgo
Copy link
Owner

@rmosolgo rmosolgo commented Jul 20, 2024

I'm hoping to add tracing options using ActiveRecord::QueryLogs, also trying out Fiber::[], as suggested in #4993 (comment)

Fixes #4946

TODO:

  • Consider adding Fiber[:current_multiplex] and sourcing operation_name from there
  • Add unit tests for Current, test when no query is running
  • Add to Rails generator

@rmosolgo rmosolgo added this to the 2.3.11 milestone Aug 1, 2024
@rmosolgo rmosolgo merged commit 225c4ff into master Aug 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate with ActiveRecord::QueryLogs (old marginalia)
1 participant