Make kafka listeners great again #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build was failing with python3. Latest version of pip ensures deps are installed much faster.
python/docker-compose*.yml were failing with ``` Error response from daemon: pull access denied for python_kafka_test_client, repository does not exist or may require 'docker login': denied: requested access to the resource is denied ``` This will ensure it builds as the compose file is started.
so yes that file is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two fixes in this Pull Request both required to ensure this works out of the box.
This will ensure it builds as the compose file is started.
Update python/Dockerfile to use python3.8
Build was failing with python3.
Latest version of pip ensures deps are installed much faster.
Fix python/docker-compose*.yml
python/docker-compose*.yml were failing with
FWIW: I'm not sure of the point of
python/docker-compose_initial.yml- Unless we need it could we delete it?