Name remux threads #221
Merged
Name remux threads #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives the threads custom names to easily identify which thread is doing work in tools like htop.
|
|
raisjn
reviewed
May 25, 2024
|
|
||
| - name: "Build artifacts" | ||
| run: | | ||
| ARCH=rm make docker | ||
| ARCH=kobo make docker | ||
| CROSS_TC=arm-kobo-linux-gnueabihf DOCKERFILE=Dockerfile.kobo FBINK=1 TARGET=kobo make docker |
There was a problem hiding this comment.
not sure we need this change or if using target=kobo is enough
There was a problem hiding this comment.
I was copying what was in the stable-release action. Should they both be changed to just TARGET=kobo?
rmkit/.github/workflows/stable-release.yml
Lines 29 to 30 in 381ef9d
There was a problem hiding this comment.
ah, thanks for fixing it here, then. I think i trust stable release, since that's been running and uploading artifacts
raisjn
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives the threads custom names to easily identify which thread is doing work in tools like htop.