-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid colons in filenames #218
Conversation
thanks for doing this! looks good, but worth testing before merge |
Agreed on testing for sure, if someone with a dev env already set up would be kind enough to help there I'd be very grateful. |
PFA the built file (had to upload as .tar.gz) |
Tyvm for the build! What's PFA? |
PFA = please find attached. sorry about the corp speak |
Thanks! I'm going to be afk for a few days, I'll see about testing that when I get back. |
Finally got back to this! There were actually a couple more functions using I've tested this last commit, all functionality appears to be working correctly. |
Fixes #217
I haven't tested this, I'm on windows right now and don't have make. But it seems pretty straightforward.