Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid colons in filenames #218

Merged
merged 3 commits into from
May 13, 2024

Conversation

suddjian
Copy link
Contributor

@suddjian suddjian commented Mar 25, 2024

Fixes #217

I haven't tested this, I'm on windows right now and don't have make. But it seems pretty straightforward.

@raisjn
Copy link
Member

raisjn commented Mar 25, 2024

thanks for doing this! looks good, but worth testing before merge

@suddjian
Copy link
Contributor Author

Agreed on testing for sure, if someone with a dev env already set up would be kind enough to help there I'd be very grateful.

@raisjn
Copy link
Member

raisjn commented Mar 25, 2024

harmony.tar.gz

PFA the built file (had to upload as .tar.gz)

@suddjian
Copy link
Contributor Author

Tyvm for the build! What's PFA?

@raisjn
Copy link
Member

raisjn commented Mar 25, 2024

PFA = please find attached. sorry about the corp speak

@suddjian
Copy link
Contributor Author

Thanks! I'm going to be afk for a few days, I'll see about testing that when I get back.

@suddjian
Copy link
Contributor Author

suddjian commented May 11, 2024

Finally got back to this! There were actually a couple more functions using get_date that I didn't find before. It looks like get_date is only used for generating file names, so I decided to change the way it formats the date instead of adding an extra sanitization step. (though this is my first time working with cpython, so maybe double check that)

I've tested this last commit, all functionality appears to be working correctly.

@raisjn raisjn merged commit 4692106 into rmkit-dev:master May 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[harmony] project filenames are invalid on Windows because of date formatting
2 participants