-
Notifications
You must be signed in to change notification settings - Fork 5
Share Gupnla by link #35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Hmm, this git workflow thing looks nice. Looks like you changed
What's with that? So the root is "dist/deploy" for the git workflow? |
|
Yes, the root is <link rel="stylesheet" href="dist/css/bundle.min.css"/>
<script src="dist/js/bundle.min.js" type="text/javascript"></script>But I'm new to |
|
I created a self-contained commit for the share functionality here: I noticed it does not account for marks. It's a great idea, but I haven't tried to pass IDs into the data set. It would be easier if each part had an ID in the data. I have that information, but it changes sometimes, so it's very volatile... The Git workflow stuff is cool. Maybe I will mess around with it. I would probably build the link behind the scenes and add a share button to copy the link. |
Maybe stick with name as ID, or hash the name would be easier for maintenance. How do you think about that?
My first attempt to encode data into URL parameter resulting URL with 6xxxx characters which IE won't support, so I only encode the name and parts. I'm not sure if including marks would be okay. |
Other players usually share their Gunpla as a screen capture, which consume mobile data, takes time to show, and is hard for other to change their Gunpla.
This PR adds ability to share selected Gunpla parts and gears by link, also allow others to modify with the link.
example link
NOTE: this PR comes with GitHub Action to deploy to GitHub pages, let me know if it is not suitable for you.