Add support for USB logging on peripheral - #1000
Open
tompre wants to merge 2 commits into
Open
Conversation
Collaborator
|
Thanks for the work! Comments from me:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds usb init function and logging task for the peripheral depending on the
usb_logfeature flag.Should this be a separate feature?
Currently this works for nrf52 only, should I add support for rp2040?
Currently peripheral usb logging is mutually exclusive with dfu, should I create a common usb_task for the two? Would that even work with the available hardware resources?
It changes the default log level to trace, so one can change the log level without touching rmk code. I added docs for this.
Let me know if I should change anything.