Make fit_flux=True the default when init=zero #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmjarvis
force-pushed
the
pixelgrid_fit_flux
branch
from
2a450de to
6bec722
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes some confusing behavior when using the SumPSF class. The default initialization for components after the first one is zero, which means they get initialized to have zero flux.
However, GSObjectModel and PixelGrid both default to using flux=1 all the time. (All models do really, but these two have the ability to not do so.) If you don't turn that off, then the second component confusingly keeps setting itself to flux=1, which negates the zero initialization. This tripped us (@kklaliotis) up today when we were trying to figure out why the SumPSF was behaving so badly on LSSTCam data.
So now, whenever init=zero (either specified explicitly or by default when showing up as a non-first component in a Sum), fit_flux is automatically set to True. This seems like more intuitive behavior.