Skip to content

[Close pending] Unreachable AgentRole branch — the file is deleted in Phase 3 #138

Description

@rmems

Note

Historical GitHub issue. This issue is closed and retained for provenance. Its original body may describe an older writ/worktrees-hives architecture; do not treat retired Python/lab, Research-Hive, hook-enforcement, managed-worktree, babysit, or blanket local-merge restrictions below as current requirements.
Current product direction: https://linear.app/rpd-34/issue/RM-116/epic-writ-parallel-subagent-collaboration-ownership-and-conflict
Linear is the required task tracker; GitHub keeps source/PR/review/check history.

Important

Product goal (2026-09-05): writ (formerly worktrees-hives) is the enforcement and admission-control layer for agent fleets. Coordination is commoditized — Claude Code agent teams, /batch, Cursor /multitask and Codex already assign and isolate work. What nothing enforces is safe concurrent writing. writ enforces at the git mutation boundary through Claude Code hooks (a PreToolUse exit 2 cannot be overridden, even by another hook's permissionDecision: "allow"), leases worktrees it did not create, and never merges. Prefer work that hardens that boundary over creating worktrees or re-implementing coordination.

Caution

Slated for closure as not planned. Held open pending explicit disposition authority. Do not implement.

Why

The fix is two deleted lines in python/src/worktrees_hives/lab_jobs.py. That file is deleted in its entirety in Phase 3 of #1, along with the rest of python/. Implementing this would be work whose entire artifact is removed in a later phase of the same plan.

The finding itself was valid: _parse_agent_role declares role: AgentRole | str while AgentRole inherits enum.StrEnum, so both declared input variants satisfy isinstance(role, str) and the if not isinstance(role, str): return role branch is unreachable. It was correctly reported by Qodana and correctly triaged.

The process note worth keeping

One low-severity unreachable-code warning produced a tracked issue with nine acceptance criteria, a file-ownership blocker, a Linear twin, and a parent epic link — for deleting two lines. That ratio is the reason #124's operating rules say external analyzers are advisory until reproduced, and why #1's non-goals now state plainly: run the analyzers, do not file their output.

Parent: #124 · Superseded by: Phase 3 of #1

Activity

  1. self-assigned this
    on Aug 31, 2026
  2. linear-code commented on Aug 31, 2026

    @linear-code
    Contributor
  3. moved this from Backlog to Ready in Autonomous Software Engineeringon Aug 31, 2026
  4. changed the title [-][Hygiene] Remove unreachable AgentRole parser branch[/-] [+][Close pending] Unreachable AgentRole branch — the file is deleted in Phase 3[/+] on Sep 6, 2026
  5. rmems commented on Sep 6, 2026

    @rmems
    OwnerAuthor

    Closing as not planned under the 2026-09-05 pivot in #1 (writ — enforcement and admission control for agent fleets). Disposition authority given by Raul, 2026-09-05.

    The issue body records why this is closed and, where anything of substance survived, which issue now owns it. Nothing here is lost silently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions